fix(bluebubbles): call stop typing on idle and NO_REPLY #1439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Upstream PR was merged to blue bubbles. Doesn't hurt to merge this now, will start working once the new bb server is released/adopted. Without the new server these calls do the opposite of what they're supposed to do, but they don't hurt. |
Previously, typing stop was intentionally skipped because the BlueBubbles Server DELETE endpoint was bugged (called startTyping instead of stopTyping). Now that the server bug is fixed, we can properly stop typing indicators. - onIdle: now calls sendBlueBubblesTyping(false) to stop typing - finally block: stops typing when no message sent (NO_REPLY case)
095e3fc to
3993c9a
Compare
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes typing indicators not being stopped when:
Background
The typing stop was previously disabled because BlueBubbles Server had a bug where the DELETE
/typingendpoint calledstartTyping()instead ofstopTyping(). That bug has been fixed (PR pending in BlueBubbles Server), so we can now properly stop typing indicators.Changes
onIdle: now callssendBlueBubblesTyping(false)to stop typingfinallyblock: stops typing when no message was sent (NO_REPLY case)Related