Thanks to visit codestin.com
Credit goes to github.com

Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: moov-io/signedxml
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: monzo/signedxml
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 6 commits
  • 5 files changed
  • 2 contributors

Commits on Jun 14, 2018

  1. Use lowercase id= attributes

    liclac committed Jun 14, 2018
    Configuration menu
    Copy the full SHA
    f68015c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6c357cb View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2018

  1. Configuration menu
    Copy the full SHA
    6631159 View commit details
    Browse the repository at this point in the history
  2. Added to README.md as well

    liclac committed Aug 6, 2018
    Configuration menu
    Copy the full SHA
    a311547 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. Fix issue where adjacent comments were skipped during canonicalization

    Addresses issue #50
    
    If comments were adjacent in a document with no whitespace between them, then for each pair of comments the second comment would be skipped due to the underlying slice being modified as it was being ranged over.
    
    For example, the following document:
    
    ```xml
    <a><!-- comment1 --><!-- comment2 --><!-- comment 3 --></a>
    ```
    
    Would be incorrectly canonicalized to:
    
    ```xml
    <a><!-- comment2 --></a>
    ```
    
    This patch fixes that issue and adds a new test case to cover it.
    laurenkt committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    1a6135b View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1 from laurenkt/adjacent-comments-not-removed

    Fix issue where adjacent comments were skipped during canonicalization
    laurenkt authored Mar 18, 2024
    Configuration menu
    Copy the full SHA
    4fd93b1 View commit details
    Browse the repository at this point in the history
Loading