Upgrade to latest LS protocol (#2164)

d3r3kk · Aman Agarwal · commit 033029a11869 · 2018-08-30T14:13:08.000-07:00
* LS symbol providers
* Different ready wait
* Upgrade dependencies to latest LS
* Make open files only default
* Turn off hash checks
* Fix double progress display
* Update packages
* Anchor dependencies
* Add missing mock from vscode-mock
* Downgrade pylint to &lt; 2.0.0 to mirror prospector requirements
diff --git a/news/1 Enhancements/2000.md b/news/1 Enhancements/2000.md
@@ -0,0 +1 @@
+Only report Language Server download progress once. (Thanks @MikhailArkhipov)
diff --git a/news/1 Enhancements/2113.md b/news/1 Enhancements/2113.md
@@ -0,0 +1 @@
+Set default analysis for language server to open files only. (Thanks @MikhailArkhipov)
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -40,7 +40,7 @@
         "theme": "dark"
     },
     "engines": {
-        "vscode": "^1.23.0"
+        "vscode": "^1.25.0"
     },
     "recommendations": [
         "donjayamanne.jupyter"
@@ -1277,7 +1277,7 @@
                 },
                 "python.analysis.openFilesOnly": {
                     "type": "boolean",
-                    "default": false,
+                    "default": true,
                     "description": "Only show errors and warnings for open files rather than for the entire workspace.",
                     "scope": "resource"
                 },
@@ -1964,7 +1964,7 @@
         "fs-extra": "4.0.3",
         "fuzzy": "0.1.3",
         "get-port": "3.2.0",
-        "glob": "^7.1.2",
+        "glob": "7.1.2",
         "iconv-lite": "0.4.21",
         "inversify": "4.11.1",
         "line-by-line": "0.1.6",
@@ -1990,8 +1990,9 @@
         "vscode-debugadapter": "1.28.0",
         "vscode-debugprotocol": "1.28.0",
         "vscode-extension-telemetry": "0.0.15",
-        "vscode-languageclient": "3.5.1",
-        "vscode-languageserver": "3.5.1",
+        "vscode-languageclient": "4.3.0",
+        "vscode-languageserver": "4.3.0",
+        "vscode-languageserver-protocol": "3.9.0",
         "winreg": "1.2.4",
         "xml2js": "0.4.19"
     },
diff --git a/requirements.txt b/requirements.txt
@@ -4,7 +4,7 @@ flake8
 autopep8
 black ; python_version>='3.6'
 yapf
-pylint
+pylint<2.0.0
 pep8
 prospector
 pydocstyle
diff --git a/src/client/activation/downloader.ts b/src/client/activation/downloader.ts
@@ -11,7 +11,6 @@ import { createDeferred } from '../common/helpers';
 import { IFileSystem, IPlatformService } from '../common/platform/types';
 import { IExtensionContext, IOutputChannel } from '../common/types';
 import { IServiceContainer } from '../ioc/types';
-import { HashVerifier } from './hashVerifier';
 import { PlatformData } from './platformData';
 
 // tslint:disable-next-line:no-require-imports no-var-requires
@@ -42,7 +41,6 @@ export class LanguageServerDownloader {
         let localTempFilePath = '';
         try {
             localTempFilePath = await this.downloadFile(downloadUriPrefix, enginePackageFileName, 'Downloading Microsoft Python Language Server... ');
-            await this.verifyDownload(localTempFilePath, platformString);
             await this.unpackArchive(context.extensionPath, localTempFilePath);
         } catch (err) {
             this.output.appendLine('failed.');
@@ -70,8 +68,7 @@ export class LanguageServerDownloader {
         });
 
         await window.withProgress({
-            location: ProgressLocation.Window,
-            title
+            location: ProgressLocation.Window
         }, (progress) => {
 
             requestProgress(request(uri))
@@ -98,16 +95,6 @@ export class LanguageServerDownloader {
         return tempFile.filePath;
     }
 
-    private async verifyDownload(filePath: string, platformString: string): Promise<void> {
-        this.output.appendLine('');
-        this.output.append('Verifying download... ');
-        const verifier = new HashVerifier();
-        if (!await verifier.verifyHash(filePath, platformString, await this.platformData.getExpectedHash())) {
-            throw new Error('Hash of the downloaded file does not match.');
-        }
-        this.output.appendLine('valid.');
-    }
-
     private async unpackArchive(extensionPath: string, tempFilePath: string): Promise<void> {
         this.output.append('Unpacking archive... ');
 
diff --git a/src/client/activation/languageServer.ts b/src/client/activation/languageServer.ts
@@ -232,7 +232,7 @@ export class LanguageServerExtensionActivator implements IExtensionActivator {
                     properties
                 },
                 displayOptions: {
-                    preferredFormat: 1, // Markdown
+                    preferredFormat: 'markdown',
                     trimDocumentationLines: false,
                     maxDocumentationLineLength: 0,
                     trimDocumentationText: false,
diff --git a/src/test/vscode-mock.ts b/src/test/vscode-mock.ts
@@ -64,6 +64,7 @@ mockedVSCode.EventEmitter = vscodeMocks.vscMock.EventEmitter;
 mockedVSCode.ConfigurationTarget = vscodeMocks.vscMockExtHostedTypes.ConfigurationTarget;
 mockedVSCode.StatusBarAlignment = vscodeMocks.vscMockExtHostedTypes.StatusBarAlignment;
 mockedVSCode.SignatureHelp = vscodeMocks.vscMockExtHostedTypes.SignatureHelp;
+mockedVSCode.DocumentLink = vscodeMocks.vscMockExtHostedTypes.DocumentLink;
 
 // This API is used in src/client/telemetry/telemetry.ts
 const extensions = TypeMoq.Mock.ofType<typeof vscode.extensions>();

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Only report Language Server download progress once. (Thanks @MikhailArkhipov)`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Set default analysis for language server to open files only. (Thanks @MikhailArkhipov)`