Make previous BadCast change optional.

hughsando · hughsando · commit a4f8687f8422 · 2015-01-01T08:31:56.000+08:00
diff --git a/Changes.md b/Changes.md
@@ -1,4 +1,5 @@
 
+* Reverted change that automatically threw 'BadCast'.  Now required HXCPP_STRICT_CASTS
 ------------------------------------------------------------
 * Cached dynamic versions of small ints and 1-char-strings for speed
 * Added support for weak hashes - needs latest haxe version
diff --git a/include/hx/Object.h b/include/hx/Object.h
@@ -191,7 +191,11 @@ class ObjectPtr
    inline ObjectPtr(const ObjectPtr<SOURCE_> &inObjectPtr)
    {
       if (!SetPtr(inObjectPtr.mPtr))
+      #ifdef HXCPP_STRICT_CASTS
          CastPtr(inObjectPtr.mPtr,true);
+      #else
+         CastPtr(inObjectPtr.mPtr,false);
+      #endif
    }
 
    template<typename SOURCE_>
diff --git a/toolchain/common-defines.xml b/toolchain/common-defines.xml
@@ -18,6 +18,7 @@
  <flag value="-I${dll_import_include}" if="dll_import_include"/>
  <flag value="-DHXCPP_DLL_EXPORT" if="dll_export"/>
  <flag value="-DHXCPP_SCRIPTABLE" if="scriptable"/>
+ <flag value="-DHXCPP_STRICT_CASTS" if="HXCPP_STRICT_CASTS"/>
  <flag value='-DHXCPP_DEBUG_HOST="${HXCPP_DEBUG_HOST}"' if="HXCPP_DEBUG_HOST" />
  <flag value='-DHXCPP_API_LEVEL=${removeQuotes:hxcpp_api_level}' if="hxcpp_api_level" />
  <flag value='-DHXCPP_API_LEVEL=0' unless="hxcpp_api_level" />

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`
	`2`	`+* Reverted change that automatically threw 'BadCast'. Now required HXCPP_STRICT_CASTS`
`2`	`3`	`------------------------------------------------------------`
`3`	`4`	`* Cached dynamic versions of small ints and 1-char-strings for speed`
`4`	`5`	`* Added support for weak hashes - needs latest haxe version`
Original file line number	Diff line number	Diff line change
`@@ -191,7 +191,11 @@ class ObjectPtr`
`191`	`191`	`inline ObjectPtr(const ObjectPtr<SOURCE_> &inObjectPtr)`
`192`	`192`	`{`
`193`	`193`	`if (!SetPtr(inObjectPtr.mPtr))`
	`194`	`+ #ifdef HXCPP_STRICT_CASTS`
`194`	`195`	`CastPtr(inObjectPtr.mPtr,true);`
	`196`	`+ #else`
	`197`	`+ CastPtr(inObjectPtr.mPtr,false);`
	`198`	`+ #endif`
`195`	`199`	`}`
`196`	`200`
`197`	`201`	`template<typename SOURCE_>`