Bug 1824871: Rename endPass -> end on GPURenderPassEncoder, GPUComputePassEncoder. r=webidl,webgpu-reviewers,teoxoy,smaug

jimblandy · jimblandy · commit 0b85dc8089ae · 2023-04-12T17:52:07.000Z
These were renamed in [gpuweb#2560](gpuweb/gpuweb#2560). Differential Revision: https://phabricator.services.mozilla.com/D173785
diff --git a/dom/webgpu/ComputePassEncoder.cpp b/dom/webgpu/ComputePassEncoder.cpp
@@ -96,7 +96,7 @@ void ComputePassEncoder::InsertDebugMarker(const nsAString& aString) {
   }
 }
 
-void ComputePassEncoder::EndPass(ErrorResult& aRv) {
+void ComputePassEncoder::End(ErrorResult& aRv) {
   if (mValid) {
     mValid = false;
     auto* pass = mPass.forget();
diff --git a/dom/webgpu/ComputePassEncoder.h b/dom/webgpu/ComputePassEncoder.h
@@ -66,7 +66,7 @@ class ComputePassEncoder final : public ObjectBase,
   void PopDebugGroup();
   void InsertDebugMarker(const nsAString& aString);
 
-  void EndPass(ErrorResult& aRv);
+  void End(ErrorResult& aRv);
 };
 
 }  // namespace webgpu
diff --git a/dom/webgpu/RenderPassEncoder.cpp b/dom/webgpu/RenderPassEncoder.cpp
@@ -304,7 +304,7 @@ void RenderPassEncoder::InsertDebugMarker(const nsAString& aString) {
   }
 }
 
-void RenderPassEncoder::EndPass(ErrorResult& aRv) {
+void RenderPassEncoder::End(ErrorResult& aRv) {
   if (mValid) {
     mValid = false;
     auto* pass = mPass.forget();
diff --git a/dom/webgpu/RenderPassEncoder.h b/dom/webgpu/RenderPassEncoder.h
@@ -95,7 +95,7 @@ class RenderPassEncoder final : public ObjectBase,
   void ExecuteBundles(
       const dom::Sequence<OwningNonNull<RenderBundle>>& aBundles);
 
-  void EndPass(ErrorResult& aRv);
+  void End(ErrorResult& aRv);
 };
 
 }  // namespace webgpu
diff --git a/dom/webgpu/mochitest/test_submit_compute_empty.html b/dom/webgpu/mochitest/test_submit_compute_empty.html
@@ -15,7 +15,7 @@
   const device = await adapter.requestDevice();
   const encoder = device.createCommandEncoder();
   const pass = encoder.beginComputePass();
-  pass.endPass();
+  pass.end();
   const command_buffer = encoder.finish();
   device.queue.submit([command_buffer]);
   ok(command_buffer !== undefined, 'command_buffer !== undefined');
diff --git a/dom/webgpu/mochitest/test_submit_render_empty.html b/dom/webgpu/mochitest/test_submit_render_empty.html
@@ -36,7 +36,7 @@
     }],
   });
   pass.executeBundles([bundle]);
-  pass.endPass();
+  pass.end();
   const command_buffer = encoder.finish();
 
   device.queue.submit([command_buffer]);
diff --git a/dom/webgpu/mochitest/test_submit_render_empty.worker.js b/dom/webgpu/mochitest/test_submit_render_empty.worker.js
@@ -27,7 +27,7 @@ self.addEventListener("message", async function(event) {
       ],
     });
     pass.executeBundles([bundle]);
-    pass.endPass();
+    pass.end();
     const command_buffer = encoder.finish();
 
     device.queue.submit([command_buffer]);
diff --git a/dom/webidl/WebGPU.webidl b/dom/webidl/WebGPU.webidl
@@ -885,7 +885,7 @@ interface GPUComputePassEncoder {
     undefined dispatchWorkgroupsIndirect(GPUBuffer indirectBuffer, GPUSize64 indirectOffset);
 
     [Throws]
-    undefined endPass();
+    undefined end();
 };
 GPUComputePassEncoder includes GPUObjectBase;
 GPUComputePassEncoder includes GPUProgrammablePassEncoder;
@@ -939,7 +939,7 @@ interface GPURenderPassEncoder {
     undefined executeBundles(sequence<GPURenderBundle> bundles);
 
     [Throws]
-    undefined endPass();
+    undefined end();
 };
 GPURenderPassEncoder includes GPUObjectBase;
 GPURenderPassEncoder includes GPUProgrammablePassEncoder;

Original file line number	Diff line number	Diff line change
`@@ -96,7 +96,7 @@ void ComputePassEncoder::InsertDebugMarker(const nsAString& aString) {`
`96`	`96`	`}`
`97`	`97`	`}`
`98`	`98`
`99`		`-void ComputePassEncoder::EndPass(ErrorResult& aRv) {`
	`99`	`+void ComputePassEncoder::End(ErrorResult& aRv) {`
`100`	`100`	`if (mValid) {`
`101`	`101`	`mValid = false;`
`102`	`102`	`auto* pass = mPass.forget();`
Original file line number	Diff line number	Diff line change
`@@ -304,7 +304,7 @@ void RenderPassEncoder::InsertDebugMarker(const nsAString& aString) {`
`304`	`304`	`}`
`305`	`305`	`}`
`306`	`306`
`307`		`-void RenderPassEncoder::EndPass(ErrorResult& aRv) {`
	`307`	`+void RenderPassEncoder::End(ErrorResult& aRv) {`
`308`	`308`	`if (mValid) {`
`309`	`309`	`mValid = false;`
`310`	`310`	`auto* pass = mPass.forget();`