Drop the click dependency

ekohl · ekohl · commit 484faf1fd93d · 2021-09-23T22:39:46.000+02:00
This reduces the number of external dependencies and relies more on
Python's standard library.

It drops the --no-push option since argparse doesn't support having a
--option / --no-option. That's also the default and this makes it
clearer to the user what the default is.

The help text's formatting is slightly different. Mostly visible are
that the description and epilog are no longer indented.
diff --git a/PyGitUp/gitup.py b/PyGitUp/gitup.py
@@ -8,6 +8,7 @@
 ###############################################################################
 
 # Python libs
+import argparse
 import codecs
 import errno
 import sys
@@ -29,7 +30,6 @@
 else:  # pragma: no cover
     NO_DISTRIBUTE = False
 
-import click
 import colorama
 from git import Repo, GitCmdObjectDB
 from termcolor import colored
@@ -534,46 +534,43 @@ def print_error(self, error):
 '''
 
 
-@click.command(epilog=EPILOG)
-@click.option('-V', '--version', is_flag=True,
-              help='Show version (and if there is a newer version).')
-@click.option('-q', '--quiet', is_flag=True,
-              help='Be quiet, only print error messages.')
-@click.option('--no-fetch', '--no-f', is_flag=True,
-              help='Don\'t try to fetch from origin.')
-@click.option('-p', '--push/--no-push', default=None,
-              help='Push the changes after pulling successfully.')
-@click.help_option('-h', '--help')
-def run(version, quiet, no_fetch, push, **kwargs):  # pragma: no cover
+def run():  # pragma: no cover
     """
     A nicer `git pull`.
     """
-    if version:
+
+    parser = argparse.ArgumentParser(description="A nicer `git pull`.", epilog=EPILOG)
+    parser.add_argument('-V', '--version', action='store_true',
+                        help='Show version (and if there is a newer version).')
+    parser.add_argument('-q', '--quiet', action='store_true',
+                        help='Be quiet, only print error messages.')
+    parser.add_argument('--no-fetch', '--no-f', dest='fetch', action='store_false',
+                        help='Don\'t try to fetch from origin.')
+    parser.add_argument('-p', '--push', action='store_true',
+                        help='Push the changes after pulling successfully.')
+
+    args = parser.parse_args()
+
+    if args.version:
         if NO_DISTRIBUTE:
             print(colored('Please install \'git-up\' via pip in order to '
                           'get version information.', 'yellow'))
         else:
             GitUp(sparse=True).version_info()
         return
 
-    if quiet:
+    if args.quiet:
         sys.stdout = StringIO()
 
     try:
         gitup = GitUp()
-
-        if push is not None:
-            gitup.settings['push.auto'] = push
-
-        # if arguments['--no-fetch'] or arguments['--no-f']:
-        if no_fetch:
-            gitup.should_fetch = False
-
+        gitup.settings['push.auto'] = args.push
+        gitup.should_fetch = args.fetch
     except GitError:
         sys.exit(1)  # Error in constructor
     else:
         gitup.run()
 
 
 if __name__ == '__main__':  # pragma: no cover
-    run(help_option_names=['-h'])
+    run()
diff --git a/poetry.lock b/poetry.lock
diff --git a/pyproject.toml b/pyproject.toml
@@ -29,7 +29,6 @@ classifiers = [
 [tool.poetry.dependencies]
 python = "^3.7"
 GitPython = "^3.0.0"
-click = "^8.0"
 colorama = "^0.4.0"
 termcolor = "^1.1.0"
 
