fix: violations of the rule of 5

muggenhor · muggenhor · commit af80786a4855 · 2026-02-20T18:14:17.000+01:00
I.e. explicitly declare all special member functions or none.

It is okay to implicitly cause the copy operators to be removed by
defining the move operators or vice versa.
diff --git a/.clang-tidy b/.clang-tidy
@@ -21,5 +21,7 @@ CheckOptions:
  - { key: readability-braces-around-statements.ShortStatementLines, value: 3 }
  - { key: readability-implicit-bool-conversion.AllowPointerConditions, value: true }
  - { key: readability-implicit-bool-conversion.AllowIntegerConditions, value: true }
+ - { key: cppcoreguidelines-special-member-functions.AllowImplicitlyDeletedCopyOrMove, value: true }
+ - { key: cppcoreguidelines-special-member-functions.AllowMissingMoveFunctionsWhenCopyIsDeleted, value: true }
 
 HeaderFilterRegex: '.*/(src/.*|include/.*)[.]hpp'
diff --git a/include/awesome/assert.hpp b/include/awesome/assert.hpp
@@ -72,6 +72,11 @@ namespace AwesomeAssert
     virtual ~stringifier() noexcept;
     virtual std::ostream& convert(std::ostream& os) const = 0;
 
+  protected:
+    stringifier() = default;
+    stringifier(stringifier&&) = default;
+    stringifier& operator=(stringifier&&) = default;
+
   private:
     friend struct detail::bool_expression;
     // Must be inline to ensure the compiler has the full body available for constant propagation
@@ -264,9 +269,6 @@ namespace AwesomeAssert
       {
       }
 
-      bool_expression(bool_expression&& rhs) = default;
-      bool_expression& operator=(bool_expression&& rhs) = default;
-
       AWESOME_CXX23_CONSTEXPR const_iterator begin() const noexcept
       {
         return const_iterator{fail_expression.get()};
@@ -610,7 +612,6 @@ namespace AwesomeAssert
   struct violation_info
   {
     violation_info() = default;
-    violation_info(violation_info&& rhs) = default;
 
     AWESOME_CXX23_CONSTEXPR violation_info(
         const char*                     file
diff --git a/test/simple.cpp b/test/simple.cpp
@@ -36,6 +36,7 @@ struct move_only_t
 
   move_only_t(move_only_t&&) = default;
   move_only_t& operator=(move_only_t&&) = default;
+  ~move_only_t() = default;
 
   // modifying operators are purposefully by-value to force the params to be r-values.
   friend constexpr move_only_t operator<<(move_only_t lhs, move_only_t rhs) noexcept
