schema: develop damp#1176
Conversation
|
pinging @rettinghaus and @ahankinson for another review |
|
I'll look this through tomorrow. Thanks. |
| <classes> | ||
| <memberOf key="att.duration.ges"/> | ||
| <memberOf key="att.timestamp2.ges"/> | ||
| </classes> |
There was a problem hiding this comment.
This should be empty, as damp is a single event without extend.
There was a problem hiding this comment.
| <classes> | |
| <memberOf key="att.duration.ges"/> | |
| <memberOf key="att.timestamp2.ges"/> | |
| </classes> | |
| <classes /> |
There was a problem hiding this comment.
@bwbohl it should be like this:
| <classes> | |
| <memberOf key="att.duration.ges"/> | |
| <memberOf key="att.timestamp2.ges"/> | |
| </classes> | |
| <classes> | |
| <empty/> | |
| </classes> |
Co-authored-by: Klaus Rettinghaus <[email protected]>
Co-authored-by: Klaus Rettinghaus <[email protected]>
Co-authored-by: Klaus Rettinghaus <[email protected]>
…imestampe2.log Co-authored-by: Klaus Rettinghaus <[email protected]>
|
With this |
|
I wouldn't delete them right away. Instead, I would document the fact that they're deprecated and when they're expected to be actually removed. |
|
Maybe a little late, but I converted this PR to a draft as we work out its details. |
| </elementSpec> | ||
| <elementSpec ident="damp" module="MEI.CMN"> | ||
| <gloss versionDate="2023-05-27" xml:lang="en">damp</gloss> | ||
| <desc xml:lang="en">An instruction to dampen one or more strings of a plucked string instrument, such as the guitar or harp.</desc> |
There was a problem hiding this comment.
On second thought, some composers have also used this symbol to indicate the damping of a percussion instrument. Maybe we state something like "An instruction to dampen a sound, usually…"?
There was a problem hiding this comment.
| <desc xml:lang="en">An instruction to dampen one or more strings of a plucked string instrument, such as the guitar or harp.</desc> | |
| <desc xml:lang="en">An instruction to dampen a sound, <abbr>e.g.</abbr>, one or more strings of a plucked string instrument, such as the guitar or harp.</desc> |
| <classes> | ||
| <memberOf key="att.duration.ges"/> | ||
| <memberOf key="att.timestamp2.ges"/> | ||
| </classes> |
| <desc xml:lang="en">Visual domain attributes.</desc> | ||
| <classes> | ||
| <memberOf key="att.placementRelStaff"/> | ||
| <memberOf key="att.verticalGroup"/> |
There was a problem hiding this comment.
| <memberOf key="att.verticalGroup"/> | |
| <memberOf key="att.verticalGroup"/> |
There was a problem hiding this comment.
I don’t see the intention behind this suggestion… please help me @rettinghaus
| <desc xml:lang="en">Visual domain attributes.</desc> | ||
| <classes> | ||
| <memberOf key="att.placementRelStaff"/> | ||
| <memberOf key="att.verticalGroup"/> |
There was a problem hiding this comment.
| <memberOf key="att.verticalGroup"/> | |
| <memberOf key="att.extSym"/> | |
| <memberOf key="att.verticalGroup"/> |
| </valItem> | ||
| <valItem ident="damp"> | ||
| <desc xml:lang="en">Stop harp string from sounding (Unicode 1D1B4).</desc> | ||
| <desc xml:lang="en">Stop harp string from sounding (Unicode 1D1B4). DEPRECATED! DELETION PLANNED FOR V. 6.</desc> |
There was a problem hiding this comment.
We should use ODDs deprecation warning mechanisms for this
This PR adds a new specialized
<damp>element based on the more generic<dir>element.Fixes #845