Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@Frando
Copy link
Member

@Frando Frando commented Nov 4, 2025

Description

This ports iroh-blobs to n0-error.

Breaking Changes

Notes & open questions

Change checklist

  • Self-review.
  • Documentation updates following the style guide, if relevant.
  • Tests if relevant.
  • All breaking changes documented.

@Frando Frando mentioned this pull request Nov 4, 2025
@n0bot n0bot bot added this to iroh Nov 4, 2025
@github-project-automation github-project-automation bot moved this to 🏗 In progress in iroh Nov 4, 2025
@github-actions
Copy link

github-actions bot commented Nov 4, 2025

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh-blobs/pr/191/docs/iroh_blobs/

Last updated: 2025-11-12T11:16:48Z

@Frando Frando marked this pull request as ready for review November 5, 2025 18:26
@ramfox
Copy link
Member

ramfox commented Nov 6, 2025

Just a note, rudi requested that we hold off on merging this PR & doing the full n0-error conversion for the next release.

Copy link
Member

@matheus23 matheus23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, submitting because otherwise github won't let me comment things without attaching them to my "review".

@Frando Frando changed the title deps: port to iroh-main and n0-error deps: port to n0-error Nov 12, 2025
@Frando
Copy link
Member Author

Frando commented Nov 12, 2025

Updated this branch for iroh-blobs main and reverted the examples to use anyhow.

Copy link
Collaborator

@rklaehn rklaehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a pretty mechanical transformation. Thanks!

use n0_error::{Result, StdResultExt};
#[tokio::main]
async fn main() -> anyhow::Result<()> {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we decided to use anyhow in examples, how about we also keep using anyhow in the readme, which is kinda an example?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🏗 In progress

Development

Successfully merging this pull request may close these issues.

6 participants