fix(typescript-estree): fix regression introduced in typescript-eslint#1525 (typescript-eslint#1543)

armano2 · web-flow · commit bec45722dfed · 2020-01-29T12:59:40.000-08:00
diff --git a/packages/typescript-estree/src/convert.ts b/packages/typescript-estree/src/convert.ts
@@ -379,10 +379,7 @@ export class Converter {
    * property instead of a kind property. Recursively copies all children.
    */
   private deeplyCopy(node: TSNode): any {
-    if (
-      node.kind >= SyntaxKind.FirstJSDocNode &&
-      node.kind <= SyntaxKind.LastJSDocNode
-    ) {
+    if (node.kind === ts.SyntaxKind.JSDocFunctionType) {
       throw createError(
         this.ast,
         node.pos,
diff --git a/packages/typescript-estree/tests/lib/convert.ts b/packages/typescript-estree/tests/lib/convert.ts
@@ -239,8 +239,9 @@ describe('convert', () => {
 
   it('should throw error on jsDoc node', () => {
     const jsDocCode = [
-      'type foo = ?foo<T> | ?(() => void)?',
-      'var a: function(b): c;',
+      'const x: function(new: number, string);',
+      'const x: function(this: number, string);',
+      'var g: function(number, number): number;',
     ];
 
     for (const code of jsDocCode) {
