Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore(go.d): log skipped data collection #21423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ilyam8 merged 2 commits into from
Dec 8, 2025
Merged

chore(go.d): log skipped data collection #21423

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec2b477
chore(go.d): log skipped data collection
ilyam8 Dec 8, 2025
be61953
improve message
ilyam8 Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/go/plugin/go.d/agent/module/job.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,8 @@ type Job struct {
// Dump mode support
dumpMode bool
dumpAnalyzer interface{} // Will be *agent.DumpAnalyzer but avoid circular dependency

consecutiveSkips int // tracks consecutive tick skips
}

type collectedMetrics struct {
Expand Down Expand Up @@ -299,8 +301,13 @@ func (j *Job) UpdateVnode(vnode *vnodes.VirtualNode) {
func (j *Job) Tick(clock int) {
select {
case j.tick <- clock:
j.consecutiveSkips = 0
default:
j.Debug("skip the tick due to previous run hasn't been finished")
if j.consecutiveSkips++; j.consecutiveSkips >= 2 {
j.Warningf("skipping data collection: previous run is still in progress (skipped %d times in a row)", j.consecutiveSkips)
} else {
j.Info("skipping data collection: previous run is still in progress")
}
}
}

Expand Down
Loading