Fix *SslEngineTest to not throw ClassCastException and pass in all cases #9588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Due some bug we did endup with ClassCastExceptions in some cases. Beside this we also did not correctly handle the case when ReferenceCountedOpenSslEngineTest did produce tasks to run in on test. Modifications: - Correctly unwrap the engine before to fix ClassCastExceptions - Run delegated tasks when needed. Result: All tests pass with different OpenSSL implementations (OpenSSL, BoringSSL etc)
normanmaurer
added a commit
that referenced
this pull request
Sep 21, 2019
…ses (#9588) Motivation: Due some bug we did endup with ClassCastExceptions in some cases. Beside this we also did not correctly handle the case when ReferenceCountedOpenSslEngineTest did produce tasks to run in on test. Modifications: - Correctly unwrap the engine before to fix ClassCastExceptions - Run delegated tasks when needed. Result: All tests pass with different OpenSSL implementations (OpenSSL, BoringSSL etc)
This was referenced Mar 9, 2021
Open
Open
Open
Closed
This was referenced Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Due some bug we did endup with ClassCastExceptions in some cases. Beside this we also did not correctly handle the case when ReferenceCountedOpenSslEngineTest did produce tasks to run in on test.
Modifications:
Result:
All tests pass with different OpenSSL implementations (OpenSSL, BoringSSL etc)