Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Cleanup repository#1409

Merged
susnux merged 3 commits intomasterfrom
cleanup
Nov 14, 2023
Merged

Cleanup repository#1409
susnux merged 3 commits intomasterfrom
cleanup

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Nov 12, 2023

  • Remove unneeded handlebars scrips
  • Fix stylelint config and add CI workflow for it
  • Move JS mocks so they are located next to the tests
  • Migrate deprecated ::v-deep to :deep

@susnux susnux requested review from artonge and miaulalala November 12, 2023 16:08
artonge
artonge requested changes Nov 13, 2023
View reviewed changes
@susnux susnux requested a review from artonge November 14, 2023 08:40
@artonge
Copy link
Collaborator

artonge commented Nov 14, 2023

/compile amend /

@artonge
Copy link
Collaborator

artonge commented Nov 14, 2023

Node CI is failing a lot recently. Has there been a change in node or npm version?

@susnux
chore: Cleanup repository
3c7f4c7 
* Remove unneeded handlebars scrips
* Fix stylelint config and add CI workflow for it
* Move JS mocks so they are located next to the tests

Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux susnux force-pushed the cleanup branch 2 times, most recently from 7801bec to 2f6d441 Compare November 14, 2023 10:40
@susnux
Copy link
Contributor Author

susnux commented Nov 14, 2023

/compile amend/

@nextcloud-command
chore(assets): Recompile assets
1baf471 
Signed-off-by: nextcloud-command <[email protected]>
@susnux
Copy link
Contributor Author

susnux commented Nov 14, 2023

Node CI is failing a lot recently. Has there been a change in node or npm version?

No there is something weird going on, the assets I compile locally slightly differ from what the CI is compiling.
But I use exactly the same NPM and node version, same dependencies (npm ci).

@susnux susnux merged commit e7e49f1 into master Nov 14, 2023
@susnux susnux deleted the cleanup branch November 14, 2023 12:47
@blizzz blizzz mentioned this pull request Nov 14, 2023
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Nov 27, 2023

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artonge artonge artonge approved these changes

@miaulalala miaulalala Awaiting requested review from miaulalala

Assignees

No one assigned

Labels

3. to review feedback-requested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@susnux @artonge @nextcloud-command