fix: prepare() threw \InvalidArgumentException which is deprecated#1859
Merged
nickvergessen merged 1 commit intomasterfrom Jan 21, 2025
Merged
fix: prepare() threw \InvalidArgumentException which is deprecated#1859nickvergessen merged 1 commit intomasterfrom
nickvergessen merged 1 commit intomasterfrom
Conversation
Signed-off-by: Joas Schilling <[email protected]>
Activity
|
||||||||||||||||||||||||||||||||||||||||
| Project |
Activity
|
| Branch Review |
bugfix/noid/notification-handling
|
| Run status |
|
| Run duration | 01m 19s |
| Commit |
|
| Committer | Joas Schilling |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
2
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
8
|
Passing
|
0
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
sidebar.cy.ts • 1 failed test • Run E2E
| Test | Artifacts | |
|---|---|---|
| Check activity listing in the sidebar > Has creation activity |
Test Replay
Screenshots
|
|
settings.cy.ts • 1 failed test • Run E2E
| Test | Artifacts | |
|---|---|---|
| Check that user's settings survive a reload > Form survive a reload |
Test Replay
Screenshots
|
|
miaulalala
approved these changes
Jan 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a user has any notifications this log is generated all the time: