Conversation
The -1 can cause the last byte to not end up in the request body (incomplete file), causing the server to time out because it expects the content length to be one byte larger. However, this one byte that isn't loaded and isn't sent is present in the file. I was able to successfully test this and it fixed the error for me. Signed-off-by: Alexander-Ger-Reich <[email protected]>
Contributor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1745 +/- ##
============================================
+ Coverage 43.07% 43.09% +0.02%
- Complexity 988 989 +1
============================================
Files 235 235
Lines 8562 8562
Branches 1119 1119
============================================
+ Hits 3688 3690 +2
+ Misses 4359 4358 -1
+ Partials 515 514 -1
🚀 New features to boost your workflow:
|
|
Did this one also hit a roadblock? |
Contributor
What does Analysis do and why does it fail? |
I'm new to this codebase but have a look at this. Warning count has increased and theres also message about stuff becoming an error in Kotlin. https://github.com/nextcloud/android-library/actions/runs/15683089591/job/44179251411?pr=1745 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is solely intended to run all CI tests of #1724, which is a community contribution by @Alexander-Ger-Reich. Due to our security policies, we cannot run CI tests on forked repositories. Consequently, all changes have been pushed to a branch within this repository. This pull request shall be closed in favour of #1724 once all tests have been completed.