Use php8 attributes instead of phpdoc annotations#25122
Closed
ChristophWurst wants to merge 1 commit intomasterfrom
Closed
Use php8 attributes instead of phpdoc annotations#25122ChristophWurst wants to merge 1 commit intomasterfrom
ChristophWurst wants to merge 1 commit intomasterfrom
Conversation
Signed-off-by: Christoph Wurst <[email protected]>
Member
|
Do we want to close this for now? As we can't really depend on it fully yet anyway. |
Member
Author
We can thanks to the polyfill. This can be done today. We just need consent on how we want to do this. |
Member
|
Ok let us discuss next week then |
Member
Author
soooo let's :) |
Member
|
What are the pros and cons? Because it is basically a this infront of the method, right: (and the correct import statement in the |
Member
|
I just noticed that there is a forum post 🙈 Let me read that. Edit: Replied there. |
Member
Author
|
This was a PoC. Will resume this work when time allows. For now I've opened a separate PR to phase out the annotation reflector: #27544 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is more an experiment or PoC than anything mergeable. As I wrote this bit of code I realized there are a few things that we might want to discuss before we jump onto this new feature and change our public API for this. Hence I'd wait for 22 so we don't rush anything.
I'll open a dev forum post about this to get some input.https://help.nextcloud.com/t/how-should-we-use-php8-attributes/104278