Merged
Conversation
b8faf10 to
07bee47
Compare
Member
|
I'd say we get this in as a fix. Dropping the legacy hooks would be a bigger change that we should rather do early in the release cycle so we catch possibly missed usages early. Edit: #14552 for reference on the legacy event methods |
juliusknorr
reviewed
Jun 15, 2021
MorrisJobke
reviewed
Jun 16, 2021
MorrisJobke
approved these changes
Jun 16, 2021
Member
MorrisJobke
left a comment
There was a problem hiding this comment.
Beside the nitpick this looks fine 👍
07bee47 to
e50e0d8
Compare
Signed-off-by: Louis Chemineau <[email protected]>
e50e0d8 to
be42a13
Compare
Contributor
Author
|
Comment added. Ready to get merged :) |
juliusknorr
approved these changes
Jun 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A regression was introduced by #26727. This reverts one of the changes that causes share creation activities to not be dispatched.
This was caught by https://github.com/nextcloud/activity/pull/593/checks?check_run_id=2822075000.
Another solution would be to update the code to drop legacy API, but I don't want to dive into that without a more informed opinion.
FYI: It is probably due to a linter removing the variable because it is unused. We only need the side-effects from the constructor.
@icewind1991, @juliushaertl or @MorrisJobke ?