Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add ldap:reset-group command to unmap groups from LDAP#31661

Merged
blizzz merged 4 commits intomasterfrom
enh/user_ldap-add-command-to-unmap-groups
Apr 5, 2022
Merged

Add ldap:reset-group command to unmap groups from LDAP#31661
blizzz merged 4 commits intomasterfrom
enh/user_ldap-add-command-to-unmap-groups

Conversation

@come-nc
Copy link
Contributor

@come-nc come-nc commented Mar 22, 2022

Signed-off-by: Côme Chilliet [email protected]

@come-nc come-nc added the 3. to review Waiting for reviews label Mar 22, 2022
@come-nc come-nc added this to the Nextcloud 24 milestone Mar 22, 2022
@come-nc come-nc requested a review from blizzz March 22, 2022 11:32
@come-nc come-nc self-assigned this Mar 22, 2022
@come-nc
Copy link
Contributor Author

come-nc commented Mar 22, 2022

@blizzz Do you know why the return of deleteGroup is ignored in https://github.com/nextcloud/server/blob/master/lib/private/Group/Group.php#L357-L358 ? A boolean is returned but it’s ignored.

@skjnldsv skjnldsv mentioned this pull request Mar 24, 2022
Merged
@blizzz blizzz mentioned this pull request Mar 31, 2022
Merged
@blizzz
Copy link
Member

blizzz commented Apr 1, 2022

@blizzz Do you know why the return of deleteGroup is ignored in https://github.com/nextcloud/server/blob/master/lib/private/Group/Group.php#L357-L358 ? A boolean is returned but it’s ignored.

I am not aware of a reason of doing so, and I concur that instead of setting result blindly to true, I would OR it with the result of deleteGroup.

@come-nc
Copy link
Contributor Author

come-nc commented Apr 1, 2022

/rebase

@nextcloud-command nextcloud-command force-pushed the enh/user_ldap-add-command-to-unmap-groups branch from 02e73cf to d7a2910 Compare April 1, 2022 12:18
@come-nc come-nc requested review from a team, nickvergessen and vanpertsch and removed request for a team and vanpertsch April 4, 2022 07:33
@come-nc
Copy link
Contributor Author

come-nc commented Apr 4, 2022

@blizzz Do you know why the return of deleteGroup is ignored in https://github.com/nextcloud/server/blob/master/lib/private/Group/Group.php#L357-L358 ? A boolean is returned but it’s ignored.

I am not aware of a reason of doing so, and I concur that instead of setting result blindly to true, I would OR it with the result of deleteGroup.

I will open an other PR for this.

@come-nc come-nc requested a review from CarlSchwan April 4, 2022 11:38
@come-nc come-nc mentioned this pull request Apr 4, 2022
Merged
@blizzz blizzz merged commit 835e28d into master Apr 5, 2022
@blizzz blizzz deleted the enh/user_ldap-add-command-to-unmap-groups branch April 5, 2022 08:57
@blizzz blizzz mentioned this pull request Apr 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blizzz blizzz blizzz approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees

@come-nc come-nc

Labels

3. to review Waiting for reviews enhancement

Projects

None yet

Milestone

Nextcloud 24

Development

Successfully merging this pull request may close these issues.

3 participants

@come-nc @blizzz @CarlSchwan