Add OCS-APIRequest to list of allowed CORS headers#31698
Add OCS-APIRequest to list of allowed CORS headers#31698everlanes wants to merge 1 commit intonextcloud:masterfrom
Conversation
Adding the `OCS-APIRequest` header to the list of allowed headers This makes the OCS API usable by external web apps via XMLHttpRequest: Otherwise the access to the resource is either blocked by the OCS API (missing `OCS-APIRequest: true` header) or by the browser (`OCS-APIRequest: true` header not allowed by CORS). Signed-off-by: Andreas Brinner <[email protected]>
|
I don't think we want this as default enabled security wise. |
|
Thanks for you thoughts. But I don't agree and I try to show you why: The I only added this header to the OCSController for OCS API calls, that requires this header to be present.
I don't agree on this. The API is open to scripted attacks independent of this header parameter. So in my opinion this is kind of security by obscurity. |
Adding the
OCS-APIRequestheader to the list of allowed headersThis makes the OCS API usable by external web apps via XMLHttpRequest:
Otherwise the access to the resource is either blocked by the OCS API (missing
OCS-APIRequest: trueheader) or by the browser (OCS-APIRequest: trueheader not allowed by CORS).See Feature Request #31694