fix(updater): Stop expiring secret prematurely#49578
Merged
Conversation
9e53b31 to
232970e
Compare
Member
Author
|
/backport to stable30 |
6ee7f8c to
b77688a
Compare
b77688a to
3785f09
Compare
nickvergessen
previously requested changes
Dec 1, 2024
Merged
Merged
2ed082b to
5769ac9
Compare
5769ac9 to
4624eb3
Compare
Signed-off-by: Josh Richards <[email protected]>
4624eb3 to
a5a65dd
Compare
Contributor
|
e53025b to
32de00b
Compare
Co-authored-by: Joas Schilling <[email protected]> Signed-off-by: Ferdinand Thiessen <[email protected]> Signed-off-by: Louis Chmn <[email protected]>
32de00b to
7f3ef27
Compare
This was referenced Oct 21, 2025
Contributor
|
/backport to stable32 |
Contributor
|
Looks like this will now log a warning on each run, as the default value from |
|
Experiencing same log issue Cleared old |
6 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updater.secretcreation and expiration #45714Summary
#43967 introduced a regression in the handling of the expiration of
updater.secret. The result is thatupdater.secretis expired at the next job interval (~10 minutes). If the web Updater takes >10 minutes this prevents it from continuing.updater.secret.createdvalue when we expire a secretconfig_is_read_onlyin theAdminControllerResetTokenbackground job unit tests to catch the scenario addressed by this PRResetTokenbackground job unit test coverage in generalAdminControllerunit test coverage in generalTODO
staticused in theResetTokentest since it didn't seem to serve a purpose but I may have broken it so may require another look)Checklist