feat: add occ command to scan and selete orphaned keys #55556
+173
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hamza <[email protected]>
This comment was marked as spam.
This comment was marked as spam.
CarlSchwan
reviewed
Oct 6, 2025
| ) { | ||
| parent::__construct(); | ||
|
|
||
| $this->rootView = new View(); |
There was a problem hiding this comment.
new code should use IRootFolder instead of View
come-nc
reviewed
Oct 6, 2025
Comment on lines
+27
to
+31
| protected Util $util, | ||
| protected IConfig $config, | ||
| protected QuestionHelper $questionHelper, | ||
| private IUserManager $userManager, | ||
| private Util $encryptionUtil, |
| $path = $folder . '/' . $item['name']; | ||
| if ($this->stopCondition($path)) { | ||
| $filePath = str_replace('files_encryption/keys/', '', $path); | ||
| if (!$this->rootView->getFileInfo($filePath, true, true)) { |
Comment on lines
+123
to
+124
| return false; | ||
| } |
There was a problem hiding this comment.
Suggested change
| return false; | |
| } | |
| } | |
| return false; |
I suppose?
| return $orphanedKeys; | ||
| } | ||
|
|
||
| private function stopCondition(string $path) : bool { |
There was a problem hiding this comment.
Please add a comment explaining what the function does, when does it return true/false?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist
3. to review, feature component)stable32)