fix(UserMountCache): Add back unique index for oc_mounts and use normal insert#56933
Merged
provokateurin merged 1 commit intomasterfrom Dec 16, 2025
Merged
fix(UserMountCache): Add back unique index for oc_mounts and use normal insert#56933provokateurin merged 1 commit intomasterfrom
provokateurin merged 1 commit intomasterfrom
Conversation
This was referenced Dec 9, 2025
Altahrim
reviewed
Dec 9, 2025
SystemKeeper
reviewed
Dec 9, 2025
nickvergessen
approved these changes
Dec 10, 2025
Member
Author
|
Please review again. I only intend to backport the first commit, as the other ones are just improvements that are not strictly necessary to fix the bug. All tests should be passing now. |
ArtificialOwl
approved these changes
Dec 10, 2025
Contributor
PHPUnit failures still seems related |
Member
Author
|
Yes they are also, the files_external ones even though I don't understand why yet. |
nickvergessen
approved these changes
Dec 12, 2025
1e89141 to
460c565
Compare
…al insert Signed-off-by: provokateurin <[email protected]>
3378570 to
4449cd7
Compare
Member
Author
|
Hm sharding is stuck and an earlier run was canceled (by phpunit) due to timeout. I suspect this is related to the changes. |
4449cd7 to
341fd34
Compare
Member
Author
|
/backport to stable32 |
Member
Author
|
/backport to stable31 |
|
The backport to # Switch to the target branch and update it
git checkout stable31
git pull origin stable31
# Create the new backport branch
git checkout -b backport/56933/stable31
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 341fd348
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/56933/stable31Error: Failed to check for changes with origin/stable31: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Merged
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #56929
With the unique index back there will be no more duplicate mounts, without modifying the transaction isolation level.
Also to avoid any future issues with this method, I went ahead and removed all usage (it was deprecated in 15.0.0 already).
Oracle will likely fail on the truncate for the same still unknown reason as in #54014.