fix: Make edit mode in interactive widgets opt-in#5579
Conversation
|
/backport to stable29 |
jancborchardt
left a comment
There was a problem hiding this comment.
Looks very nice!
Maybe small adjustment so it's not vertically jumping between view and edit mode when the toolbar pops in:
In view-mode, in the space where the toolbar is, it could show the document name (in bold, left-aligned). Is that possible @juliushaertl?
Not a blocker though.
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
… vue instance Signed-off-by: Julius Härtl <[email protected]>
Yes, though I'd file as a follow up to get this in rather quickly |
jancborchardt
left a comment
There was a problem hiding this comment.
In that case all good design-wise. :)
|
The backport to # Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/5579/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 804241d0 6001f7b9 4badefff
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/5579/stable29Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/5579/stable29."} Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Fix #5532
Fix #5542
🖼️ Screenshots
View only mode
Edit mode