Cache: fixed cache stuck UPDATING if worker crashes #869
+25
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If use_stale and cache_lock used together, if the worker doing the update crashes, the flag never resets from updating and we will get stuck in UPDATING state forever.
0b73d31 to
3c8ded8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If use_stale and cache_lock used together then if the worker process doing the update crashes, the flag never resets from updating and we will get stuck in UPDATING state forever. this PR fixes this issue. (I am not sure if this solution is what you would do, but if you have an alternative solution in mind, I will update the fix)