*Always* collapse selection on yank.

smblott-github · smblott-github · commit c404f6799bb7 · 2015-06-23T06:27:38.000+01:00
This only affects the transition from visual mode back to edit mode.

Previously, we were incorrectly leaving the selection in place.

(The comment above was correct, but the implementation wasn't.)
diff --git a/content_scripts/mode_visual_edit.coffee b/content_scripts/mode_visual_edit.coffee
@@ -375,8 +375,10 @@ class Movement extends CountPrefix
   # it.
   yank: (args = {}) ->
     @yankedText = @selection.toString()
-    @selection.deleteFromDocument() if @options.deleteFromDocument or args.deleteFromDocument
-    @selection.collapseToStart() unless @options.parentMode
+    if @options.deleteFromDocument or args.deleteFromDocument
+      @selection.deleteFromDocument()
+    else
+      @selection.collapseToStart()
 
     message = @yankedText.replace /\s+/g, " "
     message = message[...12] + "..." if 15 < @yankedText.length
