Finish typing InMemorySpanExporter (open-telemetry#3285)

ngnpope · web-flow · commit 04ab744039a8 · 2023-07-12T18:24:49.000Z
diff --git a/opentelemetry-sdk/src/opentelemetry/sdk/trace/export/in_memory_span_exporter.py b/opentelemetry-sdk/src/opentelemetry/sdk/trace/export/in_memory_span_exporter.py
@@ -27,17 +27,17 @@ class InMemorySpanExporter(SpanExporter):
     :func:`.get_finished_spans` method.
     """
 
-    def __init__(self):
-        self._finished_spans = []
+    def __init__(self) -> None:
+        self._finished_spans: typing.List[ReadableSpan] = []
         self._stopped = False
         self._lock = threading.Lock()
 
-    def clear(self):
+    def clear(self) -> None:
         """Clear list of collected spans."""
         with self._lock:
             self._finished_spans.clear()
 
-    def get_finished_spans(self):
+    def get_finished_spans(self) -> typing.Tuple[ReadableSpan, ...]:
         """Get list of collected spans."""
         with self._lock:
             return tuple(self._finished_spans)
@@ -50,7 +50,7 @@ def export(self, spans: typing.Sequence[ReadableSpan]) -> SpanExportResult:
             self._finished_spans.extend(spans)
         return SpanExportResult.SUCCESS
 
-    def shutdown(self):
+    def shutdown(self) -> None:
         """Shut downs the exporter.
 
         Calls to export after the exporter has been shut down will fail.
