Revert "Merge pull request libgit2#4934 from stinb/proxy-crash"

ethomson · implausible · commit 8c7cfe37d9ba · 2019-03-06T16:57:36.000-07:00
This reverts commit 5b08a71.
diff --git a/src/transports/http.c b/src/transports/http.c
@@ -679,9 +679,6 @@ static int load_proxy_config(http_subtransport *t)
 		    !!t->server.url.use_ssl, &t->proxy_url)) < 0)
 			return error;
 
-		if (!t->proxy_url)
-			return 0;
-
 		t->proxy_opts.type = GIT_PROXY_SPECIFIED;
 		t->proxy_opts.url = t->proxy_url;
 		t->proxy_opts.credentials = t->owner->proxy.credentials;
diff --git a/tests/online/clone.c b/tests/online/clone.c
@@ -840,10 +840,3 @@ void test_online_clone__proxy_credentials_in_environment(void)
 
 	git_buf_dispose(&url);
 }
-
-void test_online_clone__proxy_auto_not_detected(void)
-{
-	g_options.fetch_opts.proxy_opts.type = GIT_PROXY_AUTO;
-
-	cl_git_pass(git_clone(&g_repo, "http://github.com/libgit2/TestGitRepository", "./foo", &g_options));
-}
