Fix leak strdup in oid

julianmesa-gitkraken · julianmesa-gitkraken · commit 9eb357eda4b1 · 2022-10-25T18:16:29.000+02:00
diff --git a/generate/templates/partials/convert_from_v8.cc b/generate/templates/partials/convert_from_v8.cc
@@ -58,8 +58,8 @@
       if (arrayVal->IsString()) {
         // Try and parse in a string to a git_oid
         Nan::Utf8String oidString(Nan::To<v8::String>(arrayVal).ToLocalChecked());
-
-        if (git_oid_fromstr(&from_{{ name }}[i], (const char *) strdup(*oidString)) != GIT_OK) {
+        string str = string(*oidString);
+        if (git_oid_fromstr(&from_{{ name }}[i], str.c_str()) != GIT_OK) {
           if (git_error_last()) {
             return Nan::ThrowError(git_error_last()->message);
           } else {
@@ -90,8 +90,8 @@
     // Try and parse in a string to a git_oid
     Nan::Utf8String oidString(Nan::To<v8::String>(info[{{ jsArg }}]).ToLocalChecked());
     git_oid *oidOut = (git_oid *)malloc(sizeof(git_oid));
-
-    if (git_oid_fromstr(oidOut, (const char *) strdup(*oidString)) != GIT_OK) {
+    string str = string(*oidString);
+    if (git_oid_fromstr(oidOut, str.c_str()) != GIT_OK) {
       free(oidOut);
 
       if (git_error_last()) {
