src: fix -Wreturn-stack-address error

codebytere · targos · commit 440d4f42bdfb · 2025-05-31T13:31:46.000+02:00
PR-URL: #58439 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
diff --git a/src/node_config_file.cc b/src/node_config_file.cc
@@ -23,7 +23,7 @@ std::optional<std::string_view> ConfigReader::GetDataFromArgs(
     } else if (it->starts_with(flag_path)) {
       // Case: "--experimental-config-file=foo"
       if (it->size() > flag_path.size() && (*it)[flag_path.size()] == '=') {
-        return it->substr(flag_path.size() + 1);
+        return std::string_view(*it).substr(flag_path.size() + 1);
       }
     } else if (*it == default_file || it->starts_with(default_file)) {
       has_default_config_file = true;

Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@ std::optional<std::string_view> ConfigReader::GetDataFromArgs(`
`23`	`23`	`} else if (it->starts_with(flag_path)) {`
`24`	`24`	`// Case: "--experimental-config-file=foo"`
`25`	`25`	`if (it->size() > flag_path.size() && (*it)[flag_path.size()] == '=') {`
`26`		`- return it->substr(flag_path.size() + 1);`
	`26`	`+ return std::string_view(*it).substr(flag_path.size() + 1);`
`27`	`27`	`}`
`28`	`28`	`} else if (*it == default_file \|\| it->starts_with(default_file)) {`
`29`	`29`	`has_default_config_file = true;`