fixup! src: add a condition if the argument of DomainToUnicode is empty

pluris · pluris · commit 4e380fda6750 · 2023-08-12T09:53:11.000+09:00
diff --git a/src/node_url.cc b/src/node_url.cc
@@ -101,8 +101,7 @@ void BindingData::DomainToUnicode(const FunctionCallbackInfo<Value>& args) {
 
   std::string input = Utf8Value(env->isolate(), args[0]).ToString();
   if (input.empty()) {
-    return args.GetReturnValue().Set(
-        String::NewFromUtf8(env->isolate(), "").ToLocalChecked());
+    return args.GetReturnValue().Set(FIXED_ONE_BYTE_STRING(env->isolate(), ""));
   }
 
   // It is important to have an initial value that contains a special scheme.

Original file line number	Diff line number	Diff line change
`@@ -101,8 +101,7 @@ void BindingData::DomainToUnicode(const FunctionCallbackInfo<Value>& args) {`
`101`	`101`
`102`	`102`	`std::string input = Utf8Value(env->isolate(), args[0]).ToString();`
`103`	`103`	`if (input.empty()) {`
`104`		`- return args.GetReturnValue().Set(`
`105`		`- String::NewFromUtf8(env->isolate(), "").ToLocalChecked());`
	`104`	`+ return args.GetReturnValue().Set(FIXED_ONE_BYTE_STRING(env->isolate(), ""));`
`106`	`105`	`}`
`107`	`106`
`108`	`107`	`// It is important to have an initial value that contains a special scheme.`