bootstrap: move global initialization to js

alenakhineika · targos · commit 6b7c6192ff70 · 2022-07-31T09:45:11.000+02:00
PR-URL: #43625 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
diff --git a/lib/internal/bootstrap/node.js b/lib/internal/bootstrap/node.js
@@ -435,6 +435,7 @@ function setupGlobalProxy() {
     enumerable: false,
     configurable: true
   });
+  globalThis.global = globalThis;
 }
 
 function setupBuffer() {
diff --git a/src/node.cc b/src/node.cc
@@ -345,11 +345,6 @@ MaybeLocal<Value> Environment::BootstrapInternalLoaders() {
 MaybeLocal<Value> Environment::BootstrapNode() {
   EscapableHandleScope scope(isolate_);
 
-  Local<Object> global = context()->Global();
-  // TODO(joyeecheung): this can be done in JS land now.
-  global->Set(context(), FIXED_ONE_BYTE_STRING(isolate_, "global"), global)
-      .Check();
-
   // process, require, internalBinding, primordials
   std::vector<Local<String>> node_params = {
       process_string(),

Original file line number	Diff line number	Diff line change
`@@ -435,6 +435,7 @@ function setupGlobalProxy() {`
`435`	`435`	`enumerable: false,`
`436`	`436`	`configurable: true`
`437`	`437`	`});`
	`438`	`+ globalThis.global = globalThis;`
`438`	`439`	`}`
`439`	`440`
`440`	`441`	`function setupBuffer() {`