Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 9d2125e

Browse files
Ayase-252dnlup
authored andcommitted
http: explain the possibilty of refactor unused argument
PR-URL: #37275 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
1 parent 9fa1f68 commit 9d2125e

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

lib/_http_incoming.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -155,6 +155,10 @@ IncomingMessage.prototype.setTimeout = function setTimeout(msecs, callback) {
155155
// argument adaptor frame creation inside V8 in case that number of actual
156156
// arguments is different from expected arguments.
157157
// Ref: https://bugs.chromium.org/p/v8/issues/detail?id=10201
158+
// NOTE: Argument adapt frame issue might be solved in V8 engine v8.9.
159+
// Refactoring `n` out might be possible when V8 is upgraded to that
160+
// version.
161+
// Ref: https://v8.dev/blog/v8-release-89
158162
IncomingMessage.prototype._read = function _read(n) {
159163
if (!this._consuming) {
160164
this._readableState.readingMore = false;

0 commit comments

Comments
 (0)