crypto: support ML-DSA KeyObject, sign, and verify #59259
Merged
+1,479
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
18133e1 to
2f37933
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
cc @nodejs/cpp-reviewers 🙏 |
521deae to
7a6c57c
Compare
This comment was marked as outdated.
This comment was marked as outdated.
panva
commented
Jul 28, 2025
panva
commented
Jul 28, 2025
panva
commented
Jul 28, 2025
7c37a1c to
3c220b4
Compare
3c220b4 to
7bd6d1e
Compare
7bd6d1e to
a08d556
Compare
|
The
notable-change
Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section. |
|
Landed in 24e28c4 |
panva
added a commit
to panva/node
that referenced
this pull request
Aug 7, 2025
PR-URL: nodejs#59259 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: James M Snell <[email protected]>
This was referenced Aug 16, 2025
This comment was marked as off-topic.
This comment was marked as off-topic.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows
node:cryptoto recognize the following asymmetric KeyObject types (keyObject.asymmetricKeyType) when built with or linked to OpenSSL 3.5 (#59234):'ml-dsa-44','ml-dsa-65','ml-dsa-87'(https://docs.openssl.org/3.5/man7/EVP_PKEY-ML-DSA/)And the following functionality for them:
crypto.createPublicKey()SPKI/JWKcrypto.createPrivateKey()PKCS#8/JWKkeyObject.export()SPKI/PKCS#8/JWKcrypto.generateKeyPair(Sync)()into KeyObject, PEM, DER, JWKcrypto.sign()and signature verification viacrypto.verify()notable-changePRs with changes that should be highlighted in changelogs.
ML-DSA support in
node:cryptokicks off post-quantum cryptography efforts in Node.js. This is part of a broader effort to support NIST's post-quantum cryptography standards for future-proofing applications against quantum computing threats.