Update homework.md

aleks-hyf · web-flow · commit 7ed1c32ec65a · 2021-09-30T21:14:18.000+02:00
The students got confused by this question, in fact the homework assignment doesn't totally make sense. Why are we getting user HackYourFuture-CPH#1 every time? I don't know the best way to write the question, but I suggested at least 1 improvement. Please ping me if you want to come up with something better.
diff --git a/javascript3/week3/homework.md b/javascript3/week3/homework.md
@@ -118,7 +118,7 @@ class ShoppingCart {
     // Implement functionality here
   }
 
-  getUser() {
+  getUser(user) {
     // Implement functionality here
   }
 }
@@ -139,7 +139,7 @@ Create the functionality for the `ShoppingCart` class.
 - `getTotal` should get the total price of the products in the `shoppingcart`.
 - `renderProducts` should render the products to html. You decide what to show and how.
 - `searchProduct` should return an array of product that match the `productName` parameter
-- `getUser` should return a promise with the data from this api: https://jsonplaceholder.typicode.com/users/1
+- `getUser` should return a promise with the data from this api: https://jsonplaceholder.typicode.com/users/1 (replace '1' with correct user). 
 
 ### Part 2
 

Original file line number	Diff line number	Diff line change
`@@ -118,7 +118,7 @@ class ShoppingCart {`
`118`	`118`	`// Implement functionality here`
`119`	`119`	`}`
`120`	`120`
`121`		`- getUser() {`
	`121`	`+ getUser(user) {`
`122`	`122`	`// Implement functionality here`
`123`	`123`	`}`
`124`	`124`	`}`
@@ -139,7 +139,7 @@ Create the functionality for the `ShoppingCart` class.
`139`	`139`	- `getTotal` should get the total price of the products in the `shoppingcart`.
`140`	`140`	- `renderProducts` should render the products to html. You decide what to show and how.
`141`	`141`	- `searchProduct` should return an array of product that match the `productName` parameter
`142`		-- `getUser` should return a promise with the data from this api: https://jsonplaceholder.typicode.com/users/1
	`142`	+- `getUser` should return a promise with the data from this api: https://jsonplaceholder.typicode.com/users/1 (replace '1' with correct user).
`143`	`143`
`144`	`144`	`### Part 2`
`145`	`145`