-
Notifications
You must be signed in to change notification settings - Fork 874
Open
Milestone
Description
With our new cancellation logic, when the user triggers a cancellation token (or CommandTimeout is reached), we attempt a PG cancellation. In async, if the PG cancellation itself fails (e.g. failure to connect because of a network partition), we immediately break the (main command's) connection.
We should look into doing the same for sync cancellation. We can't trigger a cancellation token, but IIRC it's OK to forcibly close the socket - this should immediately terminate any I/O operation stuck on that socket. This of course needs testing - and I'm not sure which exception gets thrown on the read side - but it would align sync and async behavior and is generally useful.
/cc @vonzshik
Metadata
Metadata
Assignees
Labels
No labels