feat: npm view oidc considerations (#8432)

reggi · web-flow · commit 567f15b160fe · 2025-07-14T11:01:20.000-04:00
diff --git a/lib/commands/view.js b/lib/commands/view.js
@@ -448,10 +448,12 @@ function cleanup (data) {
   }
 
   const keys = Object.keys(data)
+
   if (keys.length <= 3 && data.name && (
     (keys.length === 1) ||
     (keys.length === 3 && data.email && data.url) ||
-    (keys.length === 2 && (data.email || data.url))
+    (keys.length === 2 && (data.email || data.url)) ||
+    data.trustedPublisher
   )) {
     data = unparsePerson(data)
   }
diff --git a/test/lib/commands/view.js b/test/lib/commands/view.js
@@ -126,6 +126,34 @@ const packument = (nv, opts) => {
         '1.0.1': {},
       },
     },
+    'cyan-oidc': {
+      _npmUser: {
+        name: 'claudia',
+        email: 'claudia@cyan.com',
+        trustedPublisher: {
+          id: 'github',
+          oidcConfigId: 'oidc:a0e127d0-8d66-45d0-8264-e4f8372c7249',
+        },
+      },
+      name: 'cyan',
+      'dist-tags': {
+        latest: '1.0.0',
+      },
+      versions: {
+        '1.0.0': {
+          version: '1.0.0',
+          name: 'cyan',
+          dist: {
+            shasum: '123',
+            tarball: 'http://hm.cyan.com/1.0.0.tgz',
+            integrity: '---',
+            fileCount: 1,
+            unpackedSize: 1000000,
+          },
+        },
+        '1.0.1': {},
+      },
+    },
     brown: {
       name: 'brown',
     },
@@ -438,6 +466,12 @@ t.test('package with --json and semver range', async t => {
   t.matchSnapshot(joinedOutput())
 })
 
+t.test('package with _npmUser.trustedPublisher shows cleaned up property with --json', async t => {
+  const { view, joinedOutput } = await loadMockNpm(t, { config: { json: true } })
+  await view.exec(['cyan-oidc@^1.0.0'])
+  t.match(joinedOutput(), /claudia <claudia@cyan.com>/, 'uses oidc trustedPublisher info for _npmUser')
+})
+
 t.test('package with --json and no versions', async t => {
   const { view, joinedOutput } = await loadMockNpm(t, { config: { json: true } })
   await view.exec(['brown'])

Original file line number	Diff line number	Diff line change
`@@ -448,10 +448,12 @@ function cleanup (data) {`
`448`	`448`	`}`
`449`	`449`
`450`	`450`	`const keys = Object.keys(data)`
	`451`	`+`
`451`	`452`	`if (keys.length <= 3 && data.name && (`
`452`	`453`	`(keys.length === 1) \|\|`
`453`	`454`	`(keys.length === 3 && data.email && data.url) \|\|`
`454`		`- (keys.length === 2 && (data.email \|\| data.url))`
	`455`	`+ (keys.length === 2 && (data.email \|\| data.url)) \|\|`
	`456`	`+ data.trustedPublisher`
`455`	`457`	`)) {`
`456`	`458`	`data = unparsePerson(data)`
`457`	`459`	`}`