fix(install.sh): don't remove old npm first #3748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacs
approved these changes
Sep 13, 2021
There was a problem hiding this comment.
I believe this was to work around old versions of the npm cli that didn't clean up so gracefully if a global install got borked, especially if overwriting an existing module, but now we even handle unix signals gracefully other than SIGKILL, so I think this is the right way to go.
The install script will gracefully fail if things don't work. This is especially important for versions of npm that won't work in your current node version. PR-URL: #3748 Credit: @wraithgar Close: #3748 Reviewed-by: @isaacs
3924859 to
e4a5218
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The install script will gracefully fail if things don't work. This is
especially important for versions of npm that won't work in your current
node version.