You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Aug 11, 2022. It is now read-only.
This relates to #3059 but since that has been closed and shut down from any further interaction I will open a new issue.
The reason for calling pre-publish when initially installing local dependencies just fails me.
It might make sense to call upon pre-publish when one uses npm to install a given package from the local filesystem, but even that seems to be out of line, since the package is not going to be published to the package registry.
Please reconsider this design decision as some people require the pre-publish hook to prevent a package from being published unless some other mechanism than npm publish is being used.
I am able to overcome this by implementing a pre-publish hook such as
in order to prevent myself from running npm publish before a proper make dist including running available tests and checking for overall coverage and linting the existing sources and so on.
However, this seems to complicate things for less experienced users.
Another reason for you to reconsider your design decision should be that by making the user implement such hooks will limit the build system to a single platform, which is either windows or *nix.
The text was updated successfully, but these errors were encountered:
@othiym23 oh i missed that. thanks for pointing it out. how about just dropping the prepublishOnly stuff and just introduce the prepare and keep the pre-publish, while not calling any of these when doing a npm install in the package's directory in order to install external dependencies.
The plan as designed is a very careful balance of the needs of several different classes of users with the need to be careful about maintaining backwards compatibility, so that's what we're going to implement.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
This relates to #3059 but since that has been closed and shut down from any further interaction I will open a new issue.
The reason for calling
pre-publish
when initially installing local dependencies just fails me.It might make sense to call upon
pre-publish
when one uses npm to install a given package from the local filesystem, but even that seems to be out of line, since the package is not going to be published to the package registry.Please reconsider this design decision as some people require the
pre-publish
hook to prevent a package from being published unless some other mechanism thannpm publish
is being used.I am able to overcome this by implementing a
pre-publish
hook such asin order to prevent myself from running
npm publish
before a propermake dist
including running available tests and checking for overall coverage and linting the existing sources and so on.However, this seems to complicate things for less experienced users.
Another reason for you to reconsider your design decision should be that by making the user implement such hooks will limit the build system to a single platform, which is either windows or *nix.
The text was updated successfully, but these errors were encountered: