From c9ae7dc210e3bfb9de7f25eb33e9905ae3fdd0b5 Mon Sep 17 00:00:00 2001 From: Michael Smith Date: Mon, 20 Oct 2025 15:11:35 -0700 Subject: [PATCH 1/2] fix: some test folders need quotes for correct globbing (#535) --- lib/content/package-json.hbs | 6 +++--- test/apply/node-test.js | 12 ++++++------ 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/lib/content/package-json.hbs b/lib/content/package-json.hbs index 7c127c0d..88f65c23 100644 --- a/lib/content/package-json.hbs +++ b/lib/content/package-json.hbs @@ -18,9 +18,9 @@ "postlint": "template-oss-check", "template-oss-apply": "template-oss-apply --force", {{#if isNodeTest}} - "snap": "node --test --test-update-snapshots ./test/**/*.js", - "test": "node --test ./test/**/*.js", - "test:cover": "node --test --experimental-test-coverage --test-timeout=3000{{#if coverageThreshold}} --test-coverage-lines={{coverageThreshold}} --test-coverage-functions={{coverageThreshold}} --test-coverage-branches={{coverageThreshold}}{{/if}} ./test/**/*.js", + "snap": "node --test --test-update-snapshots './test/**/*.js'", + "test": "node --test './test/**/*.js'", + "test:cover": "node --test --experimental-test-coverage --test-timeout=3000{{#if coverageThreshold}} --test-coverage-lines={{coverageThreshold}} --test-coverage-functions={{coverageThreshold}} --test-coverage-branches={{coverageThreshold}}{{/if}} './test/**/*.js'", {{else}} "snap": "{{#if typescript}}{{#if tap16}}c8 {{/if}}{{/if}}tap", "test": "{{#if typescript}}{{#if tap16}}c8 {{/if}}{{/if}}tap", diff --git a/test/apply/node-test.js b/test/apply/node-test.js index fcdb1314..681832f4 100644 --- a/test/apply/node-test.js +++ b/test/apply/node-test.js @@ -15,12 +15,12 @@ t.test('node:test runner', async t => { const pkg = await s.readJson('package.json') // Verify test scripts are for node:test - t.equal(pkg.scripts.test, 'node --test ./test/**/*.js') + t.equal(pkg.scripts.test, "node --test './test/**/*.js'") t.equal( pkg.scripts['test:cover'], - 'node --test --experimental-test-coverage --test-timeout=3000 --test-coverage-lines=100 --test-coverage-functions=100 --test-coverage-branches=100 ./test/**/*.js', + "node --test --experimental-test-coverage --test-timeout=3000 --test-coverage-lines=100 --test-coverage-functions=100 --test-coverage-branches=100 './test/**/*.js'", ) - t.equal(pkg.scripts.snap, 'node --test --test-update-snapshots ./test/**/*.js') + t.equal(pkg.scripts.snap, "node --test --test-update-snapshots './test/**/*.js'") // Verify tap section is removed t.notOk(pkg.tap, 'tap section should not be present') @@ -51,13 +51,13 @@ t.test('node:test runner with incomplete coverage', async t => { const pkg = await s.readJson('package.json') // Verify test scripts are for node:test - t.equal(pkg.scripts.test, 'node --test ./test/**/*.js') + t.equal(pkg.scripts.test, "node --test './test/**/*.js'") t.equal( pkg.scripts['test:cover'], - 'node --test --experimental-test-coverage --test-timeout=3000 ./test/**/*.js', + "node --test --experimental-test-coverage --test-timeout=3000 './test/**/*.js'", 'test:cover should not include coverage thresholds when coverageThreshold is 0', ) - t.equal(pkg.scripts.snap, 'node --test --test-update-snapshots ./test/**/*.js') + t.equal(pkg.scripts.snap, "node --test --test-update-snapshots './test/**/*.js'") }) t.test('tap runner (default)', async t => { From 008c2fac26890eae9636d53dd3d48b5cc1eee7b2 Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Mon, 20 Oct 2025 15:14:38 -0700 Subject: [PATCH 2/2] chore: release 4.27.1 (#536) :robot: I have created a release *beep* *boop* --- ## [4.27.1](https://github.com/npm/template-oss/compare/v4.27.0...v4.27.1) (2025-10-20) ### Bug Fixes * [`c9ae7dc`](https://github.com/npm/template-oss/commit/c9ae7dc210e3bfb9de7f25eb33e9905ae3fdd0b5) [#535](https://github.com/npm/template-oss/pull/535) some test folders need quotes for correct globbing (#535) (@owlstronaut) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --- .release-please-manifest.json | 2 +- CHANGELOG.md | 4 ++++ package.json | 2 +- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/.release-please-manifest.json b/.release-please-manifest.json index 66ff287b..6a1f05fc 100644 --- a/.release-please-manifest.json +++ b/.release-please-manifest.json @@ -1,3 +1,3 @@ { - ".": "4.27.0" + ".": "4.27.1" } diff --git a/CHANGELOG.md b/CHANGELOG.md index d109c486..af9df839 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,9 @@ # Changelog +## [4.27.1](https://github.com/npm/template-oss/compare/v4.27.0...v4.27.1) (2025-10-20) +### Bug Fixes +* [`c9ae7dc`](https://github.com/npm/template-oss/commit/c9ae7dc210e3bfb9de7f25eb33e9905ae3fdd0b5) [#535](https://github.com/npm/template-oss/pull/535) some test folders need quotes for correct globbing (#535) (@owlstronaut) + ## [4.27.0](https://github.com/npm/template-oss/compare/v4.26.1...v4.27.0) (2025-10-20) ### Features * [`2e563b4`](https://github.com/npm/template-oss/commit/2e563b4defe381f18f49ccaa5ffc5d0c93d262dd) [#533](https://github.com/npm/template-oss/pull/533) adds coverageThreshold as a config, uses non-workspace dir for tests (#533) (@owlstronaut) diff --git a/package.json b/package.json index 5389a6a2..c01f2faa 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@npmcli/template-oss", - "version": "4.27.0", + "version": "4.27.1", "description": "templated files used in npm CLI team oss projects", "main": "lib/content/index.js", "bin": {