BUG: Disable broken complex trig functions for early linux glibc.

charris · charris · commit 3a4127bf53bc · 2015-02-13T09:55:41.000-07:00
The library functions casin, casinh, catan, catanh are inaccurate
in glibc version &lt; 2.16, so use the numpy fallback functions for
those.
diff --git a/numpy/core/setup_common.py b/numpy/core/setup_common.py
@@ -107,6 +107,7 @@ def check_api_version(apiversion, codegen_dir):
 # sse headers only enabled automatically on amd64/x32 builds
                 "xmmintrin.h", # SSE
                 "emmintrin.h", # SSE2
+                "features.h",  # for glibc version linux
 ]
 
 # optional gcc compiler builtins and their call arguments and optional a
diff --git a/numpy/core/src/private/npy_config.h b/numpy/core/src/private/npy_config.h
@@ -4,12 +4,6 @@
 #include "config.h"
 #include "numpy/numpyconfig.h"
 
-/* Disable broken MS math functions */
-#if defined(_MSC_VER) || defined(__MINGW32_VERSION)
-#undef HAVE_ATAN2
-#undef HAVE_HYPOT
-#endif
-
 /*
  * largest alignment the copy loops might require
  * required as string, void and complex types might get copied using larger
@@ -21,9 +15,56 @@
  */
 #define NPY_MAX_COPY_ALIGNMENT 16
 
+/* blacklist */
+
 /* Disable broken Sun Workshop Pro math functions */
 #ifdef __SUNPRO_C
+
+#undef HAVE_ATAN2
+#undef HAVE_ATAN2F
+#undef HAVE_ATAN2L
+
+#endif
+
+/* Disable broken MS math functions */
+#if defined(_MSC_VER) || defined(__MINGW32_VERSION)
+
 #undef HAVE_ATAN2
+#undef HAVE_ATAN2F
+#undef HAVE_ATAN2L
+
+#undef HAVE_HYPOT
+#undef HAVE_HYPOTF
+#undef HAVE_HYPOTL
+
 #endif
 
+/* Disable broken gnu trig functions on linux */
+#if defined(__linux__) && defined(__GNUC__)
+
+#if defined(HAVE_FEATURES_H)
+#include <features.h>
+#define TRIG_OK __GLIBC_PREREQ(2, 16)
+#else
+#define TRIG_OK 0
+#endif
+
+#if !TRIG_OK
+#undef HAVE_CASIN
+#undef HAVE_CASINF
+#undef HAVE_CASINL
+#undef HAVE_CASINH
+#undef HAVE_CASINHF
+#undef HAVE_CASINHL
+#undef HAVE_CATAN
+#undef HAVE_CATANF
+#undef HAVE_CATANL
+#undef HAVE_CATANH
+#undef HAVE_CATANHF
+#undef HAVE_CATANHL
+#endif
+#undef TRIG_OK
+
+#endif /* defined(__linux__) && defined(__GNUC__) */
+
 #endif

Original file line number	Diff line number	Diff line change
`@@ -107,6 +107,7 @@ def check_api_version(apiversion, codegen_dir):`
`107`	`107`	`# sse headers only enabled automatically on amd64/x32 builds`
`108`	`108`	`"xmmintrin.h", # SSE`
`109`	`109`	`"emmintrin.h", # SSE2`
	`110`	`+ "features.h", # for glibc version linux`
`110`	`111`	`]`
`111`	`112`
`112`	`113`	`# optional gcc compiler builtins and their call arguments and optional a`