Uses universal_newlines option for subprocess.Popen to automatically decode the output. (instead of a subsequent decode step).

Åsmund Hjulstad · Åsmund Hjulstad · commit 76bdf3b19b57 · 2015-02-06T09:20:13.000+01:00
diff --git a/numpy/distutils/lib2def.py b/numpy/distutils/lib2def.py
@@ -66,10 +66,10 @@ def getnm(nm_cmd = ['nm', '-Cs', 'python%s.lib' % py_ver]):
     """Returns the output of nm_cmd via a pipe.
 
 nm_output = getnam(nm_cmd = 'nm -Cs py_lib')"""
-    f = subprocess.Popen(nm_cmd, shell=True, stdout=subprocess.PIPE)
+    f = subprocess.Popen(nm_cmd, shell=True, stdout=subprocess.PIPE, universal_newlines=True)
     nm_output = f.stdout.read()
     f.stdout.close()
-    return nm_output.decode('ascii')
+    return nm_output
 
 def parse_nm(nm_output):
     """Returns a tuple of lists: dlist for the list of data
