Apply suggestions from code review

amcandio · eendebakpt · web-flow · commit a20f72df9f49 · 2025-12-28T20:25:14.000-08:00
Co-authored-by: Pieter Eendebak &lt;pieter.eendebak@gmail.com&gt;
diff --git a/benchmarks/benchmarks/bench_searchsorted.py b/benchmarks/benchmarks/bench_searchsorted.py
@@ -10,7 +10,7 @@ class SearchSortedInt64(Benchmark):
         [100, 10_000, 1_000_000, 1_000_000_000],       # array sizes
         [1, 2, 100, 100_000],   # number of query elements
         ['ordered', 'random'],        # query order
-        [42, 18122022]
+        [42, 18122022],   # seed
     ]
     param_names = ['array_size', 'n_queries', 'query_order', 'seed']
 
diff --git a/numpy/_core/src/npysort/binsearch.cpp b/numpy/_core/src/npysort/binsearch.cpp
@@ -104,7 +104,7 @@ binsearch(const char *arr, const char *key, char *ret, npy_intp arr_len,
     - cmp(arr[i], key_val) == true  for all i < base
     - cmp(arr[i], key_val) == false for all i >= base + length
 
-    The insertion index candidates are i in range [base, base+length] and
+    The insertion index candidates are in range [base, base+length] and
     on each iteration we shrink the range into either
         [base, ceil(length / 2)]
     or
@@ -147,8 +147,8 @@ binsearch(const char *arr, const char *key, char *ret, npy_intp arr_len,
     }
 
     /*
-    At this point interval_length == 1, so the candidates are in interval
-    [base, base + 1].
+    At this point interval_length == 1, so the candidates are in the 
+    interval [base, base + 1].
 
     We have two options:
         If cmp(arr[base], key_val) == true, insertion index is base + 1

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@ class SearchSortedInt64(Benchmark):`
`10`	`10`	`[100, 10_000, 1_000_000, 1_000_000_000], # array sizes`
`11`	`11`	`[1, 2, 100, 100_000], # number of query elements`
`12`	`12`	`['ordered', 'random'], # query order`
`13`		`- [42, 18122022]`
	`13`	`+ [42, 18122022], # seed`
`14`	`14`	`]`
`15`	`15`	`param_names = ['array_size', 'n_queries', 'query_order', 'seed']`
`16`	`16`