[DEP] Remove numpy.who

eendebakpt · eendebakpt · commit c85323c7d9e5 · 2023-08-03T12:34:31.000+02:00
diff --git a/numpy/core/tests/test_deprecations.py b/numpy/core/tests/test_deprecations.py
@@ -778,13 +778,12 @@ class TestLibImports(_DeprecationTestCase):
     # Deprecated in Numpy 1.26.0, 2023-09
     def test_lib_functions_deprecation_call(self):
         from numpy import (
-            byte_bounds, safe_eval, who, recfromcsv, recfromtxt,
+            byte_bounds, safe_eval, recfromcsv, recfromtxt,
             disp, get_array_wrap, maximum_sctype
         )
         from numpy.lib.tests.test_io import TextIO
         
         self.assert_deprecated(lambda: safe_eval("None"))
-        self.assert_deprecated(lambda: who())
 
         data_gen = lambda: TextIO('A,B\n0,1\n2,3')
         kwargs = dict(delimiter=",", missing_values="N/A", names=True)
diff --git a/numpy/lib/tests/test_regression.py b/numpy/lib/tests/test_regression.py
@@ -158,23 +158,6 @@ def test_void_coercion(self):
         x = np.zeros((1,), dt)
         assert_(np.r_[x, x].dtype == dt)
 
-    @pytest.mark.filterwarnings("ignore:.*who.*:DeprecationWarning")
-    def test_who_with_0dim_array(self):
-        # ticket #1243
-        import os
-        import sys
-
-        oldstdout = sys.stdout
-        sys.stdout = open(os.devnull, 'w')
-        try:
-            try:
-                np.who({'foo': np.array(1)})
-            except Exception:
-                raise AssertionError("ticket #1243")
-        finally:
-            sys.stdout.close()
-            sys.stdout = oldstdout
-
     def test_include_dirs(self):
         # As a sanity check, just test that get_include
         # includes something reasonable.  Somewhat
diff --git a/numpy/lib/utils.py b/numpy/lib/utils.py
@@ -14,7 +14,7 @@
 
 __all__ = [
     'issubclass_', 'issubsctype', 'issubdtype', 'deprecate',
-    'deprecate_with_doc', 'get_include', 'info', 'who',
+    'deprecate_with_doc', 'get_include', 'info',
     'byte_bounds', 'safe_eval', 'show_runtime'
     ]
 
@@ -345,116 +345,6 @@ def byte_bounds(a):
     return a_low, a_high
 
 
-#-----------------------------------------------------------------------------
-# Function for output and information on the variables used.
-#-----------------------------------------------------------------------------
-
-
-def who(vardict=None):
-    """
-    Print the NumPy arrays in the given dictionary.
-
-    .. deprecated:: 2.0
-
-    If there is no dictionary passed in or `vardict` is None then returns
-    NumPy arrays in the globals() dictionary (all NumPy arrays in the
-    namespace).
-
-    Parameters
-    ----------
-    vardict : dict, optional
-        A dictionary possibly containing ndarrays.  Default is globals().
-
-    Returns
-    -------
-    out : None
-        Returns 'None'.
-
-    Notes
-    -----
-    Prints out the name, shape, bytes and type of all of the ndarrays
-    present in `vardict`.
-
-    Examples
-    --------
-    >>> a = np.arange(10)
-    >>> b = np.ones(20)
-    >>> np.who()
-    Name            Shape            Bytes            Type
-    ===========================================================
-    a               10               80               int64
-    b               20               160              float64
-    Upper bound on total bytes  =       240
-
-    >>> d = {'x': np.arange(2.0), 'y': np.arange(3.0), 'txt': 'Some str',
-    ... 'idx':5}
-    >>> np.who(d)
-    Name            Shape            Bytes            Type
-    ===========================================================
-    x               2                16               float64
-    y               3                24               float64
-    Upper bound on total bytes  =       40
-
-    """
-
-    # Deprecated in NumPy 2.0, 2023-07-11
-    warnings.warn(
-        "`who` is deprecated. "
-        "(deprecated in NumPy 2.0)",
-        DeprecationWarning,
-        stacklevel=2
-    )
-
-    if vardict is None:
-        frame = sys._getframe().f_back
-        vardict = frame.f_globals
-    sta = []
-    cache = {}
-    for name in vardict.keys():
-        if isinstance(vardict[name], ndarray):
-            var = vardict[name]
-            idv = id(var)
-            if idv in cache.keys():
-                namestr = name + " (%s)" % cache[idv]
-                original = 0
-            else:
-                cache[idv] = name
-                namestr = name
-                original = 1
-            shapestr = " x ".join(map(str, var.shape))
-            bytestr = str(var.nbytes)
-            sta.append([namestr, shapestr, bytestr, var.dtype.name,
-                        original])
-
-    maxname = 0
-    maxshape = 0
-    maxbyte = 0
-    totalbytes = 0
-    for val in sta:
-        if maxname < len(val[0]):
-            maxname = len(val[0])
-        if maxshape < len(val[1]):
-            maxshape = len(val[1])
-        if maxbyte < len(val[2]):
-            maxbyte = len(val[2])
-        if val[4]:
-            totalbytes += int(val[2])
-
-    if len(sta) > 0:
-        sp1 = max(10, maxname)
-        sp2 = max(10, maxshape)
-        sp3 = max(10, maxbyte)
-        prval = "Name %s Shape %s Bytes %s Type" % (sp1*' ', sp2*' ', sp3*' ')
-        print(prval + "\n" + "="*(len(prval)+5) + "\n")
-
-    for val in sta:
-        print("%s %s %s %s %s %s %s" % (val[0], ' '*(sp1-len(val[0])+4),
-                                        val[1], ' '*(sp2-len(val[1])+5),
-                                        val[2], ' '*(sp3-len(val[2])+5),
-                                        val[3]))
-    print("\nUpper bound on total bytes  =       %d" % totalbytes)
-    return
-
 #-----------------------------------------------------------------------------
 
 
diff --git a/numpy/lib/utils.pyi b/numpy/lib/utils.pyi
@@ -63,8 +63,6 @@ def deprecate_with_doc(msg: None | str) -> _Deprecate: ...
 #  `byte_bounds`. This concerns `"strides"` and `"data"`.
 def byte_bounds(a: generic | ndarray[Any, Any]) -> tuple[int, int]: ...
 
-def who(vardict: None | Mapping[str, ndarray[Any, Any]] = ...) -> None: ...
-
 def info(
     object: object = ...,
     maxwidth: int = ...,
diff --git a/numpy/tests/test_public_api.py b/numpy/tests/test_public_api.py
@@ -52,7 +52,6 @@ def test_numpy_namespace():
         'set_string_function': 'numpy.core.arrayprint.set_string_function',
         'show_config': 'numpy.__config__.show',
         'show_runtime': 'numpy.lib.utils.show_runtime',
-        'who': 'numpy.lib.utils.who',
     }
     # We override dir to not show these members
     allowlist = undocumented

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,6 @@ def test_numpy_namespace():`
`52`	`52`	`'set_string_function': 'numpy.core.arrayprint.set_string_function',`
`53`	`53`	`'show_config': 'numpy.__config__.show',`
`54`	`54`	`'show_runtime': 'numpy.lib.utils.show_runtime',`
`55`		`- 'who': 'numpy.lib.utils.who',`
`56`	`55`	`}`
`57`	`56`	`# We override dir to not show these members`
`58`	`57`	`allowlist = undocumented`