Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DOC: nditer.nested_iters are not documented #10009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mattip opened this issue Nov 12, 2017 · 2 comments
Closed

DOC: nditer.nested_iters are not documented #10009

mattip opened this issue Nov 12, 2017 · 2 comments

Comments

@mattip
Copy link
Member

mattip commented Nov 12, 2017

in pull request #9998 nditers can be used as context managers to simplify writebackifcopy semantics resolution. The problem of how to resolve the semantics now percolates to the nditer.nested_iters function. In the discussion on the pull request, a few issues with nested_iters arose:

  • how to return a context-managed tuple of iterators
  • the function itself is not documented but extensively tested in test_nditers
  • the function is 321 lines of c and perhaps could be pure python (ok, I just added that now, it didn't actually come up in the pull request review)

Opening this as a reminder to fix this after the pull request #9998 is resolved

@mattip mattip changed the title ENH: nditer.nested_iters are not compliant with nditer context managers DOC: nditer.nested_iters are not documented Nov 12, 2017
@mattip
Copy link
Member Author

mattip commented Nov 12, 2017

I found a way to handle the context manager problem, all that is left is to document the function

@mattip
Copy link
Member Author

mattip commented Jan 15, 2018

Can I close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants