-
-
Notifications
You must be signed in to change notification settings - Fork 11k
invalid special value handling of avx exp #13400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This was gh-13134. @r-devulap could you have a look at this? |
yup, taking a look. |
Started a PR #13415 to fix this. Will fix the issue with log soon. |
PR #13415 is merged, perhaps this issue can be closed? |
@r-devulap just before it gets lost, was this comment a possible problem with the current fix: #13415 (comment) |
yes, unfortunately I don't have access to a mac and I cannot reproduce that problem on my SKX with ubuntu and gcc/clang. But since that portion of test |
@tylerjereddy Is the occasional |
@mattip Yes, I still get the following test failure output from the latest master branch commit (8a421d9) when running full test suite on my Mac laptop:
|
I don't think it is occasional either--I haven't see any fluke passes lately. I could use |
Hmm, this is unfortunate with 1.17 coming on soon. |
If I am not wrong, this particular issue was fixed. The test failure seems to be because of a bug in clang7.0 and a new issue was opened to address it (see #13586). Although, I am not fully sure how to address it.. |
@juliantaylor Just want to check if this can be closed. |
Closing as it seems to be fixed. I expect it will come up again if it persists. |
Unfortunately I did not comment that on the original MR but there are errors in handling special values of the new float32 avx based exp and log functions.
executed on an axv2 machine, avx512 still needs to be tested
log:
exp
The text was updated successfully, but these errors were encountered: