@rgommers wrote on 2010-07-24

I'm assuming you meant 243:

In [22]: np.base_repr(3**4, 3)
Out[22]: '10000'

In [23]: np.base_repr(3**5, 3)
Out[23]: '30000'

In [24]: np.base_repr(3**6, 3)
Out[24]: '1000000'

In [25]: 3**5
Out[25]: 243

Something does look wrong.

trac user kmaglione wrote on 2010-07-24

Sorry, you're right. I meant 243/3**5. For what it's worth, the following returns the correct answer, and 5 times faster:

#!python
def base_repr(num, base, padding=0):
    digits='0123456789abcdef'
    s=[]
    while num:
        s.append(digits[num % base])
        num /= base
    res = ''.join(reversed(s or '0'))
    if padding:
        res = '0' * padding + res
    return res

@rgommers wrote on 2010-07-25

"digits" needs to include all letters, not just a-f. A new test for 3**5 should be included as well.

Attachment added by trac user kmaglione on 2010-07-25: numpy.core.base_repr.diff

trac user kmaglione wrote on 2010-07-25

Let me know if you need more or less tests.

@rgommers wrote on 2010-07-28

Committed in r8530 and r8531. Thanks!

Milestone changed to 1.6.0 by @mwiebe on 2011-05-24