Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Color and font choice for typesetting inline code - drop the pink/red #25927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rgommers opened this issue Mar 4, 2024 · 2 comments
Closed

Comments

@rgommers
Copy link
Member

rgommers commented Mar 4, 2024

After spending a fair bit of time staring at the 2.0.0 release notes, the use of the bright red/pink color and the too-large font for text that is typeset as inline code became really jarring.

image

Compare with the docs of pydata-sphinx-theme itself:

image

That is far more pleasant to read. The theme authors have spent a lot of time polishing these choices; our bright pink/red is a leftover from the initial theme (originally from Pandas).

Proposal: switch color choices and font sizes to the theme defaults.

@rgommers
Copy link
Member Author

rgommers commented Mar 4, 2024

Got some info: we need at least 0.14.0 for the color changes (we currently have it pinned at 0.13.3), and scipy/scipy#19958 is a similar issue for SciPy that touches on some issues that the NumPy docs are also going to have (being worked on).

Upgrading to the latest version (0.15.2) locally gives the more muted colors, and deleting doc/source/_static/numpy.css files the font size problem. There are some other rendering issues, but the colors/fonts look way better:

image

@seberg
Copy link
Member

seberg commented May 6, 2024

The sphinx theme has been bumped on main, closing.

@seberg seberg closed this as completed May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants