Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fate of numpy.version in 2.0 #26072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
h-vetinari opened this issue Mar 19, 2024 · 2 comments · Fixed by #26172
Closed

Fate of numpy.version in 2.0 #26072

h-vetinari opened this issue Mar 19, 2024 · 2 comments · Fixed by #26172
Labels
62 - Python API Changes or additions to the Python API. Mailing list should usually be notified.
Milestone
2.0.0 release

Comments

@h-vetinari
Copy link
Contributor

h-vetinari commented Mar 19, 2024 •
edited
Loading

While looking at the reference (effectively) for numpy's public API, I noticed:

numpy/numpy/tests/test_public_api.py

Line 141 in 6059db1

"version" # Should be removed for NumPy 2.0

I haven't followed the finalization of 2.0 closely, so apologies if this is superfluous, but I thought I'd flag it. It wasn't mentioned in #25918 for example.

CC @rgommers @charris @seberg
@seberg
Copy link
Member

seberg commented Mar 19, 2024

I'll vote for not doing anything, the sum of all changes is already large when it comes to spending downstream annoyance chips.

@rgommers rgommers added the 62 - Python API Changes or additions to the Python API. Mailing list should usually be notified. label Mar 19, 2024
@rgommers
Copy link
Member

I agree with not doing anything. It was a minor cleanup opportunity, but the window for regular API changes for 2.0 has closed. We've asked downstream projects to do their RC1 and hopefully have our own RC1 out later this week.

I see a few more minor inaccuracies in that test, I'll open a PR to fix this comment and those other things.

@rgommers rgommers mentioned this issue Mar 29, 2024
Merged
@charris charris mentioned this issue Mar 29, 2024
Merged
@rgommers rgommers added this to the 2.0.0 release milestone Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
62 - Python API Changes or additions to the Python API. Mailing list should usually be notified.
Projects
None yet
Milestone
2.0.0 release
Development

Successfully merging a pull request may close this issue.

DOC, TST: make numpy.version officially public rgommers/numpy
3 participants
@seberg @rgommers @h-vetinari