Thanks to visit codestin.com
Credit goes to github.com

Skip to content

TEST: Doctest is not strict enough #27263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mattip opened this issue Aug 21, 2024 · 1 comment · Fixed by #27272
Closed

TEST: Doctest is not strict enough #27263

mattip opened this issue Aug 21, 2024 · 1 comment · Fixed by #27272

Comments

@mattip
Copy link
Member

mattip commented Aug 21, 2024

Over at #27257 we discovered that the new doctest runner no longer checks the string formatting, it uses np.allcose() to verify the results. At the least, it should be checking the dtype is correct, and maybe some other things like shape? cc @ev-br
@ev-br
Copy link
Contributor

ev-br commented Aug 21, 2024 •
edited
Loading

It never did, not in the refguide-check timeline anyway, that always used np.allclose. So making it more strict would be an enhancement (a fairly straightforward one).

This was referenced Aug 21, 2024
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ENH: make check-{docs,tutorials} fail on dtype mismatch ev-br/numpy
2 participants
@mattip @ev-br