-
-
Notifications
You must be signed in to change notification settings - Fork 11k
__numpy_ufunc__ confusion in docs #9252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@jbrockmendel - not sure we can still change the 1.12.0 documentation, though if it is possible, I'd be all for it. In any case, only [1] https://docs.scipy.org/doc/numpy/neps/ufunc-overrides.html, https://docs.scipy.org/doc/numpy/reference/arrays.classes.html |
Thanks, I'd been using an older version of astropy.units as a template for poking at I had seen the neps/ufunc-overrides.html page, but did not see anything saying "this is now implemented". Maybe that can go on the wish-list along with updating the 1.12.0 docs. |
Yes, someone elsewhere mentioned that the release notes seem to be missing! (It was in the e-mail @charris sent, but someone not elsewhere) |
I don't think we still want to amend the 1.12.0 docs at this point, however a
That was fixed: https://docs.scipy.org/doc/numpy/release.html
https://docs.scipy.org/doc/numpy/neps/index.html has two sections, |
The top results for Google searches like "numpy subclass ndarray" point toward the 1.12.0 docs. Three requests/suggestions.
A prominent "There is a newer version" link to the 1.13.0 docs.
The 1.12.0 page linked above directs the user to use
__numpy_ufunc__
for subclassing. I'm not entirely clear on the timeline in ENH: Add__array_ufunc__
#8247, but I couldn't make numpy_ufunc work with 1.12.0, so it isn't obvious whether the doc is accurate or (much more likely) I'm screwing up.A non-toy example for numpy_ufunc and/or array_ufunc, ideally demonstrating the tie-ins or use cases for the array_prepare/array_finalize/...
The text was updated successfully, but these errors were encountered: